Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-sync initial Ruby version #134

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Pre-sync initial Ruby version #134

merged 1 commit into from
Jun 14, 2024

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Jun 14, 2024

Currently, the bundle update --ruby is incorrectly synced on Homebrew/.github's .ruby-version rather than Homebrew/brew's.

This is because the flow goes like this:

  • .ruby-version on .github is 3.3.2
  • setup-ruby installs 3.3.2
  • sync script run under 3.3.2
  • 3.3.3 copied from Homebrew/brew to repo
  • bundler install --ruby called but the ruby installed is still 3.3.2 as we didn't run setup-ruby again
  • update to lockfile doesn't happen (until after the .ruby-version update PR is merged in Homebrew/.github)

This fixes it by doing an initial pre-sync of the ruby version prior to starting the sync script. Bundler will then operate under that new Ruby.

@MikeMcQuaid
Copy link
Member

Makes sense to me, thanks @Bo98!

@MikeMcQuaid MikeMcQuaid merged commit f14cd34 into master Jun 14, 2024
29 checks passed
@MikeMcQuaid MikeMcQuaid deleted the ruby-version-fix branch June 14, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants